RFR: 8155191: Specify that SecureRandom.nextBytes(byte[]) throws NullPointerException when byte array is null [v4]

Valerie Peng valeriep at openjdk.org
Fri May 12 23:02:58 UTC 2023


On Fri, 12 May 2023 13:39:35 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor test update, remove pkcs11 reg test as it's covered by the other
>>   test
>
> test/jdk/java/security/SecureRandom/NextBytesNull.java line 29:
> 
>> 27:  * @summary check NPE is thrown for various methods of SecureRandom class,
>> 28:  *     e.g. SecureRandom(byte[]), nextBytes(byte[]), and setSeed(byte[]).
>> 29:  * @run main NextBytesNull
> 
> You don't need an `@run` line now as this is the default if no `@run` line is specified. See https://openjdk.org/jtreg/tag-spec.html#DEFAULTS.

Sorry, didn't see this until I integrated it...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13788#discussion_r1192853571



More information about the security-dev mailing list