RFR: 8308016: Use snippets in java.io package [v2]

Alan Bateman alanb at openjdk.org
Sun May 14 06:25:47 UTC 2023


On Fri, 12 May 2023 19:02:46 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Replace `<pre>{@code ...}</pre>` patterns and the like with `{@snippet lang=java : ...}`.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8308016: Remove ellipses ("...") from snippets

src/java.base/share/classes/java/io/Console.java line 89:

> 87:  * if ((cons = System.console()) != null &&
> 88:  *     (passwd = cons.readPassword("[%s]", "Password:")) != null) {
> 89:  *     ...

I assume you didn't mean to remove this, this is show that there is other code in this block before the passwd is cleared.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13957#discussion_r1193082310



More information about the security-dev mailing list