RFR: 8298127: HSS/LMS Signature Verification [v14]

[Mark Powers]

On Mon, 15 May 2023 16:14:24 GMT, Ferenc Rakoczi <duke at openjdk.org> wrote:

>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC 8554. LMS is an approved software signing algorithm for CNSA 2.0, with SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Overrided engineSetParameters() and engineGetParameters(). Removed a comment line.

src/java.base/share/classes/sun/security/provider/HSS.java line 354:

> 352:         final String hashAlgStr;
> 353: 
> 354:         LMSParams(int type, int m, int h, String hashAlgStr) {

`type` is unused

src/java.base/share/classes/sun/security/provider/HSS.java line 667:

> 665:         protected PublicKey engineGeneratePublic(KeySpec keySpec)
> 666:                 throws InvalidKeySpecException {
> 667:             if (keySpec instanceof X509EncodedKeySpec x) {

`x` does not appear to be used

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1195787655
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1195787782