RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v6]

Kevin Driver kdriver at openjdk.org
Thu May 18 16:23:59 UTC 2023


On Wed, 17 May 2023 15:49:27 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>>> Do you have any plans to write a test? If not, the bug needs a `noreg` label.
>> 
>> As discussed internally, the test that surfaced this issue will be incorporated into regular testing. I have added `noreg-other` since none of the other labels seemed quite appropriate.
>
>> @driverkt Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See [OpenJDK Developers’ Guide](https://openjdk.org/guide/#working-with-pull-requests) for more information.
> 
> @driverkt I'm not very sure.  But per this message and the webrevs, it looks like the git use for the PR request might be able to improved by working on git branches, so that you can push the commit for every little change, and avoid force-push.

@XueleiFan @seanjmullan all comments have been addressed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13466#issuecomment-1553300216


More information about the security-dev mailing list