RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v11]

Xue-Lei Andrew Fan xuelei at openjdk.org
Thu May 18 16:46:58 UTC 2023


On Thu, 18 May 2023 16:15:39 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985)
>
> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments addressed

src/java.base/share/classes/sun/security/ssl/CertificateAuthoritiesExtension.java line 148:

> 146:                     builder.append(principal.toString());
> 147:                 } catch (IllegalArgumentException iae) {
> 148:                     builder.append("unparseable X500Principal: " + iae.getMessage());

Throwable.getMessage() may return `null`.  I may use iae.toString() instead.

`builder.append("unparseable X500Principal: " + iae);`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1198044980



More information about the security-dev mailing list