RFR: 8298127: HSS/LMS Signature Verification [v16]

Ferenc Rakoczi duke at openjdk.org
Thu May 18 19:11:36 UTC 2023


On Thu, 18 May 2023 16:18:02 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More input checks.
>
> src/java.base/share/classes/sun/security/provider/HSS.java line 410:
> 
>> 408:         final int sigLmType;
>> 409:         final int sigOtsType;
>> 410:         final private byte[] qArr;
> 
> let's remove `private` to be consistent with other fields
> Suggestion:
> 
>         final byte[] qArr;

I wanted to express that the array should be immutable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1198201763



More information about the security-dev mailing list