RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v2]

Martin Balao mbalao at openjdk.org
Thu May 18 19:30:57 UTC 2023


On Tue, 16 May 2023 23:42:08 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Martin Balao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #1)
>>   
>>   Co-authored-by: Francisco Ferrari <fferrari at redhat.com>
>>   Co-authored-by: Martin Balao <mbalao at redhat.com>
>
> src/java.base/share/classes/sun/security/util/PBEUtil.java line 62:
> 
>> 60:      * IvParameterSpec).
>> 61:      */
>> 62:     public final static class PBES2Params {
> 
> nit; static final?

Good

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12396#discussion_r1198223925



More information about the security-dev mailing list