RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v2]

Weijun Wang weijun at openjdk.org
Fri May 19 20:54:57 UTC 2023


On Fri, 19 May 2023 20:08:08 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Mark Powers has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Ferenc: comments 2 and 4
>>  - oops
>>  - Sean's comments
>>  - added @run
>
> test/jdk/sun/security/provider/lms/TestLMS.java line 30:
> 
>> 28:  * @summary tests for HSS/LMS provider
>> 29:  * @modules java.base/sun.security.util
>> 30:  * @run testng/othervm TestLMS
> 
> Why is the test run with `testng`, can this just be `main/othervm`?

I think there is even no need to use `othervm`. I see no system property modification or mutable static fields.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13940#discussion_r1199390793


More information about the security-dev mailing list