RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v18]

Kevin Driver kdriver at openjdk.org
Mon May 22 19:36:16 UTC 2023


On Fri, 19 May 2023 19:00:39 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   additional code review comments
>
> test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 28:
> 
>> 26:  * @bug 8164879
>> 27:  * @library /test/lib
>> 28:  * @summary test for proper exception handling
> 
> Suggest adding more details here, ex: "Check that an improperly encoded CA distinguished name causes a handshake failure"

addressed

> test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 45:
> 
>> 43: 
>> 44: 
>> 45: public class Test8294985 {
> 
> I would avoid putting the bug number in the test name and use something more descriptive, like InvalidEncodedCaName.

addressed

> test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 64:
> 
>> 62:             + "/../../../../javax/net/ssl/etc/keystore";
>> 63: 
>> 64:     private static byte[] payload = Base64.getDecoder().decode(
> 
> Can you add a comment as to what is in this payload?

addressed

> test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 91:
> 
>> 89:         }
>> 90: 
>> 91:         System.out.println("payload len:" + payload.length);
> 
> Is this println necessary?

addressed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1200954942
PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1200955022
PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1200955117
PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1200955187


More information about the security-dev mailing list