RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v15]

Kevin Driver kdriver at openjdk.org
Mon May 22 19:36:17 UTC 2023


On Fri, 19 May 2023 20:21:16 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fix bug id in test header
>>  - reworked example into a jtreg test
>
> test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 48:
> 
>> 46: 
>> 47:     // Test was originally written for TLSv1.2
>> 48:     private static String proto = "TLSv1.2";
> 
> Many of these could final.  Some of these are no longer used.

addressed

> test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 86:
> 
>> 84:      * Main entry point for this demo.
>> 85:      */
>> 86:     public static void main(String args[]) throws Exception {
> 
> Nit.  C Style args here instead of Java style.

addressed

> test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 104:
> 
>> 102:     }
>> 103: 
>> 104:     static Test8294985 fuzzdemoref = null;
> 
> No longer used.

addressed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1200955290
PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1200955420
PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1200955349


More information about the security-dev mailing list