RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v3]

Ferenc Rakoczi duke at openjdk.org
Tue May 23 15:11:11 UTC 2023


On Tue, 23 May 2023 00:36:26 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> https://bugs.openjdk.org/browse/JDK-8307794
>
> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Ferenc: comments 1 and 2

The code looks good to me now. I still suggest to change the file names, though.

test/jdk/sun/security/provider/lms/TestLMS.java line 59:

> 57:         for (TestCase t : TestCases) {
> 58:             if (!kat(t)) {
> 59:                 throw new RuntimeException("test case #" +i+ " failed");

Nit: "+i+" -> "+ i +"

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13940#issuecomment-1559062663
PR Review Comment: https://git.openjdk.org/jdk/pull/13940#discussion_r1202062133


More information about the security-dev mailing list