RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v19]

Kevin Driver kdriver at openjdk.org
Tue May 23 16:51:45 UTC 2023


On Tue, 23 May 2023 15:09:39 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8294985
>>  - additional code review comments
>>  - rename class and remove bug id from test header
>>  - removing block that isn't reached
>>  - fix bug id in test header
>>  - reworked example into a jtreg test
>>  - whitespace adjustments
>>  - all review comments applied
>>  - optimize imports and change toString
>>  - review comments addressed
>>  - ... and 7 more: https://git.openjdk.org/jdk/compare/98f1821e...d9f0c667
>
> test/jdk/sun/security/ssl/SSLEngineImpl/TestBadDNForPeerCA.java line 27:
> 
>> 25:  * @test
>> 26:  * @library /test/lib
>> 27:  * @summary verify correct exception handling in the event of an unparseable
> 
> Missing @bug field.

I was asked to remove it previously. I can add it back. Just looking for a consistent POV here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1202704091



More information about the security-dev mailing list