RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v19]

Xue-Lei Andrew Fan xuelei at openjdk.org
Tue May 23 18:19:09 UTC 2023


On Mon, 22 May 2023 19:41:25 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985)
>
> Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into JDK-8294985
>  - additional code review comments
>  - rename class and remove bug id from test header
>  - removing block that isn't reached
>  - fix bug id in test header
>  - reworked example into a jtreg test
>  - whitespace adjustments
>  - all review comments applied
>  - optimize imports and change toString
>  - review comments addressed
>  - ... and 7 more: https://git.openjdk.org/jdk/compare/1950bd92...d9f0c667

Changes requested by xuelei (Reviewer).

test/jdk/sun/security/ssl/SSLEngineImpl/TestBadDNForPeerCA.java line 29:

> 27:  * @summary verify correct exception handling in the event of an unparseable
> 28:  *  DN in the peer CA
> 29:  */

Please run tests for JSSE/TLS in othervm mode.  Otherwise, the behavior may be impacted with each other, and the failure debugging is pretty hard.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13466#pullrequestreview-1440319320
PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1202812974



More information about the security-dev mailing list