RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v5]

[Valerie Peng]

On Thu, 25 May 2023 23:58:00 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_MECHANISM.java line 213:
>> 
>>> 211:         sb.append(Constants.INDENT);
>>> 212:         sb.append("pParameter:");
>>> 213:         sb.append(Constants.NEWLINE);
>> 
>> Is this intended? It seems NEWLINE is not added beforehand for other fields.
>
> We found it more clear to start in a new line when showing the inner parameters. The reason is that inner parameters can be a structure (as in the PBE case) which has its own "member-name:" and new lines. It looked a bit odd when we had for example "    pParameter:    pInitVector:" in the first line and the rest of the inner structure below.

I see. Sure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12396#discussion_r1210633926