RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v24]

Kevin Driver kdriver at openjdk.org
Tue May 30 19:12:10 UTC 2023


On Tue, 30 May 2023 15:23:39 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 26 additional commits since the last revision:
>> 
>>  - Merge branch 'master' of github.com:openjdk/jdk into JDK-8294985
>>  - wrapping
>>  - addressed remaining code review comments
>>  - Merge branch 'master' of github.com:openjdk/jdk into JDK-8294985
>>  - run tests with othervm
>>  - working testcase for CertificateRequest for TLS1.2
>>  - new version of second test
>>  - initial commit of second test
>>  - reintroduce bug id to test header
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8294985
>>  - ... and 16 more: https://git.openjdk.org/jdk/compare/bbf628a3...2a35a7cc
>
> src/java.base/share/classes/sun/security/ssl/CertificateAuthoritiesExtension.java line 28:
> 
>> 26: package sun.security.ssl;
>> 27: 
>> 28: import sun.security.ssl.SSLExtension.ExtensionConsumer;
> 
> Please keep the previous import order for consistency with other code in this package. All code in `sun.security.ssl` generally orders the imports as `java`, `javax`, then internal (`sun`), etc.

we need a code style template for IDEs :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1210712213


More information about the security-dev mailing list