RFR: 8319374: JFR: Remove instrumentation for exception events [v3]

[David Holmes]

On Tue, 7 Nov 2023 11:11:31 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Could I have a review of a PR that removes the bytecode instrumentation for the exception events.
>> 
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rename field from tracing to jfrTracing

src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 62:

> 60:         if (ExceptionThrownEvent.enabled()) {
> 61:             long timestamp = ExceptionThrownEvent.timestamp();
> 62:             ExceptionThrownEvent.commit(timestamp, message, clazz);

Just a drive-by observation, but now you get the timestamp from the event it seems strange to pull it out and then pass it back to commit, instead of having a version of commit that automatically uses the internal timestamp.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16493#discussion_r1385990281