RFR: 8319374: JFR: Remove instrumentation for exception events [v3]

Erik Gahlin egahlin at openjdk.org
Wed Nov 8 15:13:12 UTC 2023


On Wed, 8 Nov 2023 13:39:10 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> I agree, and I have looked into it, but I think it's better to do that refactorization separately as it will impact other events.
>
> Just for my own understanding: in this particular case the time stamp is meaningless because the duration is expected to be 0 (or close to it) since nothing happens between the time the timestamp is taken and the time the event is committed. Is that correct?

Yes, the event has no duration.

Before https://bugs.openjdk.org/browse/JDK-8239508 we wrote timestamp and duration for all Java events. For exception events, we wrote duration = 0. Now we can differentiate between durational and instant events, which means bytecode can be generated to take the timestamp in the commit method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16493#discussion_r1386777042


More information about the security-dev mailing list