RFR: 8302233: HSS/LMS: keytool and jarsigner changes

[Sean Mullan]

On Thu, 16 Nov 2023 16:25:33 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/pkcs/PKCS7.java line 872:
>> 
>>> 870:      */
>>> 871:     @Deprecated(since="16", forRemoval=true)
>>> 872:     public static byte[] generateSignedData(byte[] signature,
>> 
>> Are you sure you want to remove this as part of this change? If there was a reason this was deprecated for removal (perhaps some apps did use it even though they should not), then before removing it it probably makes sense to include it in a CSR, and maybe the RN too.
>
> This internal method was called by `TimestampedSigner` which was removed long ago when we removed the support for `ContentSigner` and `jarsigner -altsign`. It has been useless for some time and this is just a cleanup.

Ok, I see. It probably should have been removed as part of https://bugs.openjdk.org/browse/JDK-8303410. So I'm ok with the cleanup.

It probably makes sense to rename `newGenerateSignedData` to `generateSignedData` (since there is only one method now).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14254#discussion_r1396009553