RFR: JDK-8318105 [jmh] the test java.security.HSS failed with 2 active threads

Mark Powers mpowers at openjdk.org
Fri Nov 17 17:39:32 UTC 2023


On Fri, 17 Nov 2023 17:28:40 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> https://bugs.openjdk.org/browse/JDK-8318105
>
> test/micro/org/openjdk/bench/java/security/HSS.java line 83:
> 
>> 81:     @Setup
>> 82:     public void setup() throws Exception {
>> 83:         p = Security.getProvider("SUN");
> 
> I assume this was just a "sanity check" to see whether it's an Oracle/Sun JDK? In which case, I understand removing it. However, if it has to do with the threading model and some kind of locking of the provider, you might want to add some more to your description.

Yes, it was an unnecessary sanity check.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16435#discussion_r1397660984



More information about the security-dev mailing list