RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v4]

Weijun Wang weijun at openjdk.org
Mon Nov 20 22:39:06 UTC 2023


On Mon, 20 Nov 2023 13:57:58 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> When blocksize is less than digest output length, call `keccak` more.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minimize code changes

OK, I will remove the ` = (digest length x 2)` words from `keccak()`. As for the synopsis, this bug was about the bug in SHAKE256, and I don’t know how to add SHAKE128 there. One solution is to remove `SHAKE128.java` at all from this code change, and I can add it into my other PR at [RFE 4936767: Parameters for MessageDigest](https://github.com/openjdk/jdk/pull/16660). How do you think of this?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16698#issuecomment-1819915372



More information about the security-dev mailing list