RFR: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer [v5]

Magnus Ihse Bursie ihse at openjdk.org
Tue Nov 21 13:46:09 UTC 2023


On Tue, 21 Nov 2023 12:36:24 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:

>> Hello,
>> 
>> In this PR I removed NSS tests from the ProblemList and updated NssTest to use Sqlite databases. I also removed code in PKCS11Test.java that falls back to NSS libraries installed on the test system. The tests can still be run with different NSS libraries but they have to be specified by a system property. I updated `doc/testing.md` to reflect that change.
>> 
>> Thanks
>
> Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updated documentation

doc/testing.md line 605:

> 603: correctly, the system property `jdk.test.lib.artifacts.<NAME>` is required on
> 604: Ubuntu 18.04 to specify the alternative NSS lib directory. The `<NAME>`
> 605: component should be replaced with the name element of the appropriate`@Artifact`

Space missing after "appropriate". Also please make sure you keep 80 char long lines.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16294#discussion_r1400621814



More information about the security-dev mailing list