RFR: 8318756 Create better internal buffer for AEADs

Daniel Jeliński djelinski at openjdk.org
Tue Nov 28 08:43:07 UTC 2023


On Tue, 28 Nov 2023 00:49:58 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Cipher.java line 792:
>> 
>>> 790: 
>>> 791:     /*
>>> 792:      * Optimized version of bufferCrypt from CipherSpi.java.  Direct
>> 
>> Can you document the optimizations done in this function?
>
> The second sentence says what the optimizations is.

well I was under the impression that the bulk of the optimization comes from using modified `engineGetOutputSize` that does not allocate when isUpdate== true and decrypting. That's not documented anywhere.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16487#discussion_r1407396658


More information about the security-dev mailing list