RFR: JDK-8315042 NPE in PKCS7.parseOldSignedData [v3]

Weijun Wang weijun at openjdk.org
Mon Oct 2 18:07:13 UTC 2023


On Mon, 2 Oct 2023 16:57:47 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> test/jdk/sun/security/x509/X509CRLImpl/UnexpectedNPE.java line 76:
>> 
>>> 74: 
>>> 75:         System.out.println("CRLException has not been thrown");
>>> 76:         return false;
>> 
>> I think only `generateCRLs` is enough here since neither bug is about X.509 encoding.
>
> I don't understand.

I mean there is no need to call both `generateCRL` and `generateCRLs`. The original test cases are about basic SEQUENCE encoding, the new test case is about PKCS7 encoding. These can be tested with a single `generateCRLs` call.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15844#discussion_r1342997097



More information about the security-dev mailing list