RFR: JDK-8315042 NPE in PKCS7.parseOldSignedData [v4]

Valerie Peng valeriep at openjdk.org
Mon Oct 2 22:30:24 UTC 2023


On Mon, 2 Oct 2023 22:08:48 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> test/jdk/sun/security/x509/X509CRLImpl/UnexpectedNPE.java line 27:
>> 
>>> 25:  * @test
>>> 26:  * @bug 5052433 8315042
>>> 27:  * @summary NullPointerException for generateCRL and generateCRLs methods.
>> 
>> I didn't notice the `@summary` mention both methods. Now I'm not sure which one is better. You can either update this summary to only mention one or revert the code to check both.
>
> I'll revert the code to check both.

If we are fixing the summary, can we also elaborate a little more so it's clear that the test is checking for CRLException?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15844#discussion_r1343223009


More information about the security-dev mailing list