RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

Valerie Peng valeriep at openjdk.org
Mon Oct 9 21:53:55 UTC 2023


On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> A few classes in `com.sun.crypto.provider` package have non-final fields which could easily be marked `final`.

src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java line 61:

> 59: 
> 60:     // the key bytes, without the algorithm information
> 61:     private final byte[] key;

I have an impending change which needs to re-assign key outside of constructor, thus can you leave this field as is and not marking it final?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15412#discussion_r1350813070


More information about the security-dev mailing list