RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

Valerie Peng valeriep at openjdk.org
Tue Oct 10 22:31:00 UTC 2023


On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> A few classes in `com.sun.crypto.provider` package have non-final fields which could easily be marked `final`.

src/java.base/share/classes/com/sun/crypto/provider/TlsMasterSecretGenerator.java line 165:

> 163:         private static final long serialVersionUID = 1019571680375368880L;
> 164: 
> 165:         private final byte[] key;

Again, I have an impending change which would require this field to be non-final.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15412#discussion_r1353498700



More information about the security-dev mailing list