RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package [v2]

Valerie Peng valeriep at openjdk.org
Thu Oct 12 18:20:11 UTC 2023


On Wed, 11 Oct 2023 08:16:00 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> A few classes in `com.sun.crypto.provider` package have non-final fields which could easily be marked `final`.
>
> Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge remote-tracking branch 'origin/master' into final_fields_com.sun.crypto.provider
>    
>    # Conflicts:
>    #	src/java.base/share/classes/com/sun/crypto/provider/PBEKeyFactory.java
>  - 8315974: Make fields final in 'com.sun.crypto.provider' package
>    
>    apply review suggestions
>  - [PATCH]: Make fields final in com.sun.crypto.provider package

Changes look good to me.
Thanks!

-------------

Marked as reviewed by valeriep (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15412#pullrequestreview-1674858869



More information about the security-dev mailing list