RFR: 8316964: Security tools should not call System.exit [v3]

Weijun Wang weijun at openjdk.org
Fri Oct 13 21:57:22 UTC 2023


On Fri, 13 Oct 2023 19:31:21 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   typo
>
> src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Klist.java line 155:
> 
>> 153:             } else {
>> 154:                 displayMessage("Credentials cache");
>> 155:                 return -1;
> 
> Make displayMessage(String) return -1 and just use "return displayMessage();"? (Other displayXXX() also returns int)

Sure, I've renamed to `displayError` to match the return code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15951#discussion_r1358892612


More information about the security-dev mailing list