RFR: 8316964: Security tools should not call System.exit [v4]

Andrey Turbanov aturbanov at openjdk.org
Mon Oct 16 07:08:57 UTC 2023


On Fri, 13 Oct 2023 21:57:21 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Remove most `System.exit()` calls in various security tools and only leave one in the `main` method. This paves the way to convert them to JSR 199 tools.
>> 
>> Note: before this change, the behavior of a successful `main()` method execution is not consistent. Sometimes the method returns silently, sometimes a `System.exit(0)` is called somewhere. After this change, the method always returns silently. This makes sure that existing programs that calls the `main` method directly will continue and does not exit the VM.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   displayError

src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Klist.java line 151:

> 149:                 target = CredentialsCache.getInstance(name);
> 150: 
> 151:             if (target != null)  {

Suggestion:

            if (target != null) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15951#discussion_r1360200185



More information about the security-dev mailing list