RFR: 8316964: Security tools should not call System.exit [v5]

Weijun Wang weijun at openjdk.org
Mon Oct 16 16:23:13 UTC 2023


> Remove most `System.exit()` calls in various security tools and only leave one in the `main` method. This paves the way to convert them to JSR 199 tools.
> 
> Note: before this change, the behavior of a successful `main()` method execution is not consistent. Sometimes the method returns silently, sometimes a `System.exit(0)` is called somewhere. After this change, the method always returns silently. This makes sure that existing programs that calls the `main` method directly will continue and does not exit the VM.

Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:

  inline some throw statements, remove duplicated whitespaces

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15951/files
  - new: https://git.openjdk.org/jdk/pull/15951/files/ffb17d0b..78466670

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15951&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15951&range=03-04

  Stats: 12 lines in 2 files changed: 0 ins; 4 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/15951.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15951/head:pull/15951

PR: https://git.openjdk.org/jdk/pull/15951



More information about the security-dev mailing list