RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v4]

Raffaello Giulietti rgiulietti at openjdk.org
Tue Oct 17 14:12:07 UTC 2023


On Tue, 17 Oct 2023 11:11:52 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to use try...catch to handle CharacterCodingException and throw IllegalArgumentException instead of CharacterCodingException to make the calling code cleaner.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert NoReplTest, from @cl4es 's review

@wenshao The proposal changes the exception types for seemingly no reason.
What concrete problem does this enhancement PR address?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16209#issuecomment-1766499191



More information about the security-dev mailing list