RFR: 8318096: Add getParams method in PublicKey and PrivateKey [v2]

David M. Lloyd duke at openjdk.org
Wed Oct 18 04:46:48 UTC 2023


On Tue, 17 Oct 2023 19:48:26 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Add `getParams` to `PublicKey` and `PrivateKey` so it's available to all current and future public and private keys.
>> 
>> No test. Might add one.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add spaces and code tags, and a test

Would `getParameterSpec` be a better/more descriptive name, given that the thing it returns is an `AlgorithmParameterSpec`?

(Disclosure: Our security library (WildFly Elytron) has a `getParameterSpec` on every one of its key implementation classes... it would be serendipitous if it would retroactively fit in with this change!)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16222#issuecomment-1767631116


More information about the security-dev mailing list