RFR: 8316964: Security tools should not call System.exit [v5]

Weijun Wang weijun at openjdk.org
Fri Oct 20 01:15:35 UTC 2023


On Fri, 20 Oct 2023 00:12:25 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   inline some throw statements, remove duplicated whitespaces
>
> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 425:
> 
>> 423:     }
>> 424: 
>> 425:     public int run(String[] args, PrintStream out) throws Exception {
> 
> Is this run() method used outside of this class, and thus the scope change?

This allows the tools to be called externally. These are still non-public APIs but at least with some `--add-exports` it can be called elsewhere.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15951#discussion_r1366319639



More information about the security-dev mailing list