RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v6]

Hai-May Chao hchao at openjdk.org
Fri Oct 20 22:09:36 UTC 2023


On Fri, 20 Oct 2023 18:39:38 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 150:
>> 
>>> 148:      */
>>> 149:     static {
>>> 150:         Integer clientLen = GetIntegerAction.privilegedGetProperty(
>> 
>> I think you could call `privilegedGetProperty` with the default value as second argument.
>
> If I'm looking at the latest version, I don't see @mcpowers suggestion implemented. He's suggesting using the method with this signature: 
> 
> 
> public static String privilegedGetProperty(String theProp, String defaultVal)

I did update the code with his suggestion, and please see it in webrev **01: Incremental.**  However, I further change the code based on the updated CSR, that the new client and server properties have different default values now  from the existing property, and the need to know whether the new property is explicitly set or not. We want to make sure the new properties are not overridden when they are set.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15163#discussion_r1367517385



More information about the security-dev mailing list