RFR: 8316964: Security tools should not call System.exit [v5]

Valerie Peng valeriep at openjdk.org
Tue Oct 24 16:21:31 UTC 2023


On Wed, 18 Oct 2023 17:22:31 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   inline some throw statements, remove duplicated whitespaces
>
> src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Kinit.java line 131:
> 
>> 129:         } catch (Exception e) {
>> 130:             String msg;
>> 131:             if (e instanceof KrbException) {
> 
> Let's simplify with pattern matching variable

+1. Rest looks good to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15951#discussion_r1370484614



More information about the security-dev mailing list