RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v9]

Kevin Driver kdriver at openjdk.org
Tue Oct 31 20:26:55 UTC 2023


On Tue, 31 Oct 2023 20:17:59 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12
>
> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change getInstance to not require keystore type

test/jdk/sun/security/ssl/SSLEngineImpl/TestBadDNForPeerCA.java line 108:

> 106: 
> 107:         KeyStore ks = KeyStore.getInstance(new File(keyStoreFile), passphrase);
> 108:         KeyStore ts = KeyStore.getInstance(new File(keyStoreFile), passphrase);

deliberate

test/jdk/sun/security/ssl/SSLEngineImpl/TestBadDNForPeerCA12.java line 131:

> 129: 
> 130:         KeyStore ks = KeyStore.getInstance(new File(keyStoreFile), passphrase);
> 131:         KeyStore ts = KeyStore.getInstance(new File(keyStoreFile), passphrase);

deliberate

test/jdk/sun/security/ssl/ServerHandshaker/GetPeerHost.java line 44:

> 42:         System.setProperty("javax.net.ssl.trustStore", testRoot
> 43:                             + "/../../../../javax/net/ssl/etc/truststore");
> 44:         System.setProperty("javax.net.ssl.trustStoreType", "PKCS12");

deliberate

test/jdk/sun/security/ssl/ServerHandshaker/GetPeerHost.java line 45:

> 43:                             + "/../../../../javax/net/ssl/etc/truststore");
> 44:         System.setProperty("javax.net.ssl.trustStoreType", "PKCS12");
> 45:         System.setProperty("javax.net.ssl.trustStorePassword", "passphrase");

deliberate

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16159#discussion_r1378125630
PR Review Comment: https://git.openjdk.org/jdk/pull/16159#discussion_r1378125765
PR Review Comment: https://git.openjdk.org/jdk/pull/16159#discussion_r1378126246
PR Review Comment: https://git.openjdk.org/jdk/pull/16159#discussion_r1378126354



More information about the security-dev mailing list