RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v7]

温绍锦 duke at openjdk.org
Mon Sep 11 16:40:44 UTC 2023


On Mon, 11 Sep 2023 14:28:28 GMT, Chen Liang <liach at openjdk.org> wrote:

>> 温绍锦 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move java.lang.StringLatin1::getChars to jdk.internal.util.DecimalDigits::getCharsLatin1
>
> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 143:
> 
>> 141:      * code after loop unrolling.
>> 142:      */
>> 143:     public static int stringSize(int x) {
> 
> I suggest splitting the moves of `stringSize` `getChars` into a new PR dependent on this one; your future date and time optimizations can depend on that one, which exposes stringSize.
> 
> Having the DecimalDigits package move and `stringSize` `getChars` moves together complicates the file changes, and it's hard to detect if there's any accidental typo/malicious code in the new additions.

If this PR is split into two PRs, the other two PRs I submitted #15658 #15555 cannot be based on this PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15651#discussion_r1321809367



More information about the security-dev mailing list