RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v10]

Claes Redestad redestad at openjdk.org
Mon Sep 11 18:59:46 UTC 2023


On Mon, 11 Sep 2023 15:57:22 GMT, 温绍锦 <duke at openjdk.org> wrote:

>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>> 
>> We can reduce duplication through JavaLangAccess, which is also needed in other places, such as:
>> https://github.com/openjdk/jdk/pull/15555
>
> 温绍锦 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert code format

src/java.base/share/classes/jdk/internal/util/OctalDigits.java line 37:

> 35:  * @since 21
> 36:  */
> 37: public final class OctalDigits implements Digits {

Can you restore the order of methods here to minimize the number of lines of code are touched?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15651#discussion_r1321956051



More information about the security-dev mailing list