RFR: 8315999: Improve Date toString performance [v7]

Roger Riggs rriggs at openjdk.org
Tue Sep 12 13:57:44 UTC 2023


On Tue, 12 Sep 2023 13:05:19 GMT, 温绍锦 <duke at openjdk.org> wrote:

>> improve date toString performance, includes:
>> 
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - improved DateTimeFormatter.format
>  - improved ISO_INSTANT format

You haven't make the case for these changes, please describe the use cases when performance is a significant constraint on application performance.  
The changes largely just add more code to maintain without otherwise adding sufficient value.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15658#issuecomment-1715774423



More information about the security-dev mailing list