RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

Chen Liang liach at openjdk.org
Tue Sep 12 23:16:40 UTC 2023


On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu <jlu at openjdk.org> wrote:

> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It would improve readability to see the native characters instead of escape sequences (especially for the L10n process). The majority of files changed are localized resource files.
> 
> This change converts the Unicode escape sequences in the JDK .properties files (both in src and test) to UTF-8 native characters. Additionally, the build logic is adjusted to read the .properties files in UTF-8 while generating the ListResourceBundle files.
> 
> The only escape sequence not converted was `\u0020` as this is used to denote intentional trailing white space. (E.g. `key=This is the value:\u0020`)
> 
> The conversion was done using native2ascii with options `-reverse -encoding UTF-8`.
> 
> If this PR is integrated, the IDE default encoding for .properties files need to be updated to UTF-8. (IntelliJ IDEA locks .properties files as ISO-8859-1 unless manually changed).

make/jdk/src/classes/build/tools/compileproperties/CompileProperties.java line 227:

> 225:         try (FileInputStream input = new FileInputStream(propertiesPath);
> 226:              // Read in JDK .properties files in UTF-8
> 227:              InputStreamReader streamReader = new InputStreamReader(input, StandardCharsets.UTF_8)

Can we just uses `Files.newBufferedReader(Path.of(propertiesPath))` instead?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15694#discussion_r1323716978



More information about the security-dev mailing list