RFR: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java

Aleksey Shipilev shade at openjdk.org
Wed Sep 13 21:20:07 UTC 2023


On Thu, 7 Sep 2023 13:23:01 GMT, Ian Myers <duke at openjdk.org> wrote:

> sun/security/util/math/TestIntegerModuloP.java runs in tier2 and takes about 600 seconds to run. Thus, it drags the execution time of tier2 on large machines. We can split the run configurations a bit so that test is more parallel. 
> 
> TestIntegerModuloP.java current run time: **235.02s user 6.60s system 119% cpu 3:22.69 total**
> TestIntegerModuloP.java parallelized run time: **328.75s user 14.57s system 755% cpu 45.467 total**
> 
> This change splits TestIntegerModuloP.java's previously serialized test into 11 separate tests that run in parallel.

Please go https://github.com/ianrichr/jdk/actions and enable testing for your personal fork.

Then please update copyright in the file to:


 * Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.


...and push another commit here. This will trigger testing too.

This looks fine. I suggested @ianrichr what to do for this RFE, so I would like someone else to take a look too.

Hi @robilad, could you help us with OCA verification here a bit? Thanks!

test/jdk/sun/security/util/math/TestIntegerModuloP.java line 103:

> 101:  */
> 102: 
> 103: 

Excess new line.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15618#pullrequestreview-1615439495
Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15618#pullrequestreview-1615484644
PR Comment: https://git.openjdk.org/jdk/pull/15618#issuecomment-1715606358
PR Review Comment: https://git.openjdk.org/jdk/pull/15618#discussion_r1318610805



More information about the security-dev mailing list