RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

Alan Bateman alanb at openjdk.org
Tue Sep 19 10:37:41 UTC 2023


On Wed, 6 Sep 2023 15:55:21 GMT, Tim Prinzing <tprinzing at openjdk.org> wrote:

>>> https://bugs.openjdk.org/browse/JDK-8310979 - better exception handling https://bugs.openjdk.org/browse/JDK-8310978 - missing code paths for event generation https://bugs.openjdk.org/browse/JDK-8310994 - non-blocking, event for select ops
>> 
>> Do you have a sense yet on events when the channel is configured non-blocking? I realise the threshold is 20ms so they are probably not recorded today but I wonder if these code paths will eventually include `|| !blocking` or if it useful to record data on all socket read/write ops.
>
>> > https://bugs.openjdk.org/browse/JDK-8310979 - better exception handling https://bugs.openjdk.org/browse/JDK-8310978 - missing code paths for event generation https://bugs.openjdk.org/browse/JDK-8310994 - non-blocking, event for select ops
>> 
>> Do you have a sense yet on events when the channel is configured non-blocking? I realise the threshold is 20ms so they are probably not recorded today but I wonder if these code paths will eventually include `|| !blocking` or if it useful to record data on all socket read/write ops.
> 
> I think it's useful if trying to trace the calls (i.e. set to 0ms).  Apparently the security manager was being used for that by some.

> @tprinzing 
> Your change (at version [9fa2745](https://github.com/openjdk/jdk/commit/9fa2745960aea0bc45642081bac89fb5ef65809e)) is now ready to be sponsored by a Committer.

@tprinzing I don't mind sponsoring but I think it would help if you could sync up the branch and provide a summary on the testing was done.  The jdk_net and jdk_nio test groups are in tier2. The jdk_jfr test group is in tier3.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14342#issuecomment-1725248917



More information about the security-dev mailing list