RFR: 8304956: Update KeyStore.getDefaultType() specification to return pkcs12 as fallback [v3]
Valerie Peng
valeriep at openjdk.org
Wed Sep 20 06:05:44 UTC 2023
On Tue, 19 Sep 2023 17:09:56 GMT, Ben Perez <duke at openjdk.org> wrote:
>> Replaced "jks" with "pkcs12" in both the spec and fallback for `KeyStore.getDefaultType()`
>
> Ben Perez has updated the pull request incrementally with one additional commit since the last revision:
>
> Added test to check that when keystore.type is null it defaults to pkcs12
test/jdk/java/security/KeyStore/PKCS12/CheckNullDefault.java line 2:
> 1: /*
> 2: * Copyright (c) 2023 Oracle and/or its affiliates. All rights reserved.
Where did you get the copyright from? IIRC, there should be a coma after the year and also copyright for the test file should not have the "Classpath" thing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15625#discussion_r1331040799
More information about the security-dev
mailing list