RFR: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback [v3]

Valerie Peng valeriep at openjdk.org
Wed Sep 20 17:59:43 UTC 2023


On Wed, 20 Sep 2023 15:40:47 GMT, Ben Perez <duke at openjdk.org> wrote:

>> test/jdk/java/security/KeyStore/PKCS12/CheckNullDefault.java line 2:
>> 
>>> 1: /*
>>> 2:  * Copyright (c) 2023 Oracle and/or its affiliates. All rights reserved.
>> 
>> Where did you get the copyright from? IIRC, there should be  a coma after the year and also copyright for the test file should not have the "Classpath" thing.
>
> I copied it from the CheckDefaults test - is there a more up to date one I should be using?

You can check around tests under the same directory for references. There is a recent fix which sweep through copyright typos and `CheckDefaults` happen to be one of them. You had the old one here and should be updated. Besides there is always a coma after the year convention-wise.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15625#discussion_r1331998085



More information about the security-dev mailing list