RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v5]
Magnus Ihse Bursie
ihse at openjdk.org
Thu Sep 21 09:20:55 UTC 2023
On Tue, 8 Aug 2023 19:59:52 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into patch-10
>> - Document changes in awt_DnDDS.cpp
>> - Remove negation in os_windows.cpp
>> - Mismatched declaration in D3DGlyphCache.cpp
>> - Fields in awt_TextComponent.cpp
>> - reinterpret_cast needed in AccessBridgeJavaEntryPoints.cpp
>> - Qualifiers in awt_PrintDialog.h should be removed
>> - Likewise for awt_DnDDT.cpp
>> - awt_ole.h include order issue in awt_DnDDS.cpp
>> - Revert awt_ole.h
>> - ... and 15 more: https://git.openjdk.org/jdk/compare/11d431b2...1d3d6b5e
>
> src/java.desktop/windows/native/libawt/windows/awt_DnDDT.cpp line 34:
>
>> 32: #include "sun_awt_windows_WDropTargetContextPeer.h"
>> 33: #include "awt_Container.h"
>> 34: #include "awt_ole.h"
>
> Why?
Is this related to the `#define malloc Do_Not_Use_Malloc` issue? If so, the required ordering of includes should be documented here as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1332749949
More information about the security-dev
mailing list