RFR: 8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2 [v2]

Jamil Nimeh jnimeh at openjdk.org
Thu Sep 21 17:01:41 UTC 2023


On Thu, 21 Sep 2023 13:29:10 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Please review this change to ensure this test is tested on different TLS protocols (1.0, 1.1, 1.2)
>> 
>> I added a protocol parameter to the test arguments so that different protocols are tested. I also removed the boolean exportable argument as it wasn't doing anything.
>
> Sean Mullan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Only adjust sever hello size for TLS_DHE_RSA_WITH_AES_128_CBC_SHA with TLSv1.2.
>   Fix some typos.

LGTM

-------------

Marked as reviewed by jnimeh (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15846#pullrequestreview-1638329315



More information about the security-dev mailing list