RFR: JDK-8315042 NPE in PKCS7.parseOldSignedData [v2]

Weijun Wang weijun at openjdk.org
Fri Sep 22 17:39:13 UTC 2023


On Fri, 22 Sep 2023 15:56:08 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> I was just thinking the tests are quite different. Now I re-read it and maybe we can change the old code to call `generateCRLs` as well. The existing `encoded_x` are very simple and only invalid SEQUENCES, which is not at the level of X.509 or PKCS7.
>> 
>> Therefore I'm OK with reusing this test without the `generateCRL` flag.
>
> And leave `Utils.runAndCheckException` out of the fix? I'm fine either way.

I'm OK either way too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15844#discussion_r1334660937



More information about the security-dev mailing list