RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry

Daniel Jeliński djelinski at openjdk.org
Tue Sep 26 06:16:13 UTC 2023


On Mon, 25 Sep 2023 18:12:32 GMT, Weijun Wang <weijun at openjdk.org> wrote:

> A different fix after https://github.com/openjdk/jdk/pull/14506 was closed.
> 
> Still haven't made the attributes set immutable but at least it is populated before an entry is added to `entries` and it will never be modified later.
> 
> I tried the newly added `AttributesMultiThread.java` test hundreds of times and only observed failures before this fix (~%2 failure rate).

LGTM. Thank you!

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15909#pullrequestreview-1643415588



More information about the security-dev mailing list