RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

Bradford Wetmore wetmore at openjdk.org
Thu Sep 28 17:48:42 UTC 2023


On Thu, 28 Sep 2023 05:57:58 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java line 1278:
>> 
>>> 1276:                             throw context.conContext.fatal(Alert.INTERNAL_ERROR,
>>> 1277:                                     "Unhandled exception", e);
>>> 1278:                         }
>> 
>> Is there any chance this will double alert?
>
> Not really. Only the first call to `fatal` sends an alert, subsequent calls just rethrow the given exception, wrapping it in a SSLException if necessary.

Thanks for confirming.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15148#discussion_r1340487218



More information about the security-dev mailing list