RFR: 8328785: IOException: Symbol not found: C_GetInterface for PKCS11 interface prior to V3.0 [v2]

[Valerie Peng]

On Thu, 4 Apr 2024 06:23:00 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> src/jdk.crypto.cryptoki/unix/native/libj2pkcs11/p11_md.c line 181:
> 
>> 179:     C_GetFunctionList = (CK_C_GetFunctionList) dlsym(hModule,
>> 180:             getFunctionListStr);
>> 181:     if ((systemErrorMessage = dlerror()) != NULL){
> 
> Would it make sense to move this check under `if (C_GetFunctionList == NULL)`? If `C_GetFunctionList` is non-null, do we care about the value of dlerror?

Yes, makes sense, I'll change it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18588#discussion_r1552383806